Max Zettlmeißl
Max Zettlmeißl
Using a long press for the light seems reasonable to me. It keeps the functionality and does not interfere with the backward cycling. I will change that. Thanks for your...
Thank you. The missing comment was an oversight.
I provide all my changes under the MIT license which the rest of this project uses right now. (To avoid someone having to explicitly ask like in #334.) I did...
I squashed all the various smaller corrections together and properly separated the commit with the credential changes from the commit with the backwards cycling changes.
I had a previous version of these changes already running on hardware and these changes also worked fine in the simulator, but now I deployed exactly these commits to hardware...
Sure. I'd suggest you rebase your changes on top of my branch and then post your patches (in full git format, with authorship information) or a link to your branch...
I'm not sure what to say about this now that your changes got merged. I'm sure you meant well and most of your changes were good, but you also dropped...
> I also took your suggestions seriously: I came up with a macro that makes it easy and safe to define credentials, and used compound literals in order to avoid...
> > The biggest thing that I'm missing are the default values which I had defined for the `CREDENTIAL` macro. They would make the credentials even easier to manage >...
> While exploring [the musl codebase](https://git.musl-libc.org/cgit/musl/tree/src/internal/syscall.h), I came across this wonderful piece of C preprocessor wizardry: Nice find. > Would you like to implement it? I'm not too keen on...