ledger-windows-build icon indicating copy to clipboard operation
ledger-windows-build copied to clipboard

Could we find a new home for this repository?

Open maxwell-k opened this issue 4 years ago • 3 comments

Maybe this repository should move, or even just be archived.

I started this repository at a time when I used Windows and Ledger regularly. Right now I use Linux and beancount. I'm not active in the ledger community and don't actually know where to start discussing a move; a naive starting point is perhaps that if this repository is useful it could move under https://github.com/ledger

I've accepted contributions from other contributors and appreciate the time people have spent. Right now I've become a bottle-neck - there are two open PRs that I haven't merged. A part of my reluctance is that I should review, check or at least run basic tests on code published under my name.

Do you think this repository should have a new home and/or a new maintainer?

@AndrewSav https://github.com/maxwell-k/ledger-windows-build/pull/6 or @kunedo https://github.com/maxwell-k/ledger-windows-build/pull/4 do you have opinions?

maxwell-k avatar May 10 '20 13:05 maxwell-k

I'm not sure. I spent 2-3 days a year on it in bursts, whenever I felt like it. I personally not ready to commit to keep updating it, because I, personally never used ledger. On the other hand I like up-to-date windows binary being available, so I wanted to keep my GitHub Action fork alive, should you not be able to merge it.

Having it under the main project would make total sense, but my guess is that it had to be put in a separate repo due to hurdles (or lack of interest) of accepting to main.

Cmake project and VS give numerous depreciation warning for Windows. I always fear that one day it will stop building, and we won't be able to fix that. Let's face it. the only reason we can make it work is because Cmake project allows it, if the official maintainers of ledger cannot do necessary changes to it to keep up with version changes of Cmake and VS keep updating it separately is unrealistic. This is an argument for including it in the main repo, although this particular problem has not been encountered yet.

On the other hand, I have very little exposure to Cmake, I never used it before, so I personally do not feel comfortable committing to maintaining it, and this is something that Ledger maintainers may reasonably expect if they accept it into the official repo.

Realistically, the easiest way for you is to just archive the repo. If you do, I'll keep my for up for the time being, but I probably won't be able even accepting PRs if any. Good news, that these are not often and not likely. And of course I would not be able to work on in any more often than I did in the past.

So if I was you - probe the official repo, if they are interested (unlikely but there is no reason not to try) and if not, archive.

AndrewSav avatar May 10 '20 21:05 AndrewSav

@maxwell-k Was my feedback helpful?

AndrewSav avatar Aug 16 '20 23:08 AndrewSav

@maxwell-k hello, I'm still hoping for an answer.

AndrewSav avatar Oct 16 '20 10:10 AndrewSav