python-redmine icon indicating copy to clipboard operation
python-redmine copied to clipboard

authenticating with API key is broken; request overwrites X-Redmine-Api-Key header from BaseEngine.__init__

Open dmick opened this issue 5 months ago • 4 comments

The fairly-new construct_request_kwargs() takes a param "headers" which it uses exclusively to create the request headers; however, if the engine object was instantiated with 'key', the key is stored in self.requests['headers'] already, and should be merged in construct_request_kwargs(), not overwritten

dmick avatar Jul 25 '25 20:07 dmick

It looks like this was broken in https://github.com/maxtepkeev/python-redmine/pull/343

dmick avatar Jul 25 '25 20:07 dmick

the maintainer of this project seems to be absent...

#351

erSitzt avatar Aug 13 '25 12:08 erSitzt

Thanks, yes, aware. Thought this might help, although I see a bug...new patch forthcoming

dmick avatar Aug 13 '25 16:08 dmick

tweaked the patch.

dmick avatar Aug 13 '25 17:08 dmick