python-redmine icon indicating copy to clipboard operation
python-redmine copied to clipboard
verified publisher icon maxtepkeev

Prevent exception due to value not being set

Open sposs opened this issue 5 years ago • 2 comments

In case described, the value is set to None, so it is in the dict. This raises the exception mentioned. The fix prevents the error.

sposs avatar Aug 25 '20 13:08 sposs

Coverage Status

Coverage remained the same at 98.678% when pulling e71897c6cfbf103fd03d47c9c958cce694d9c8bf on sposs:master into 85546030f1ab9c216d806dc72d3bcd5c16390162 on maxtepkeev:master.

coveralls avatar Aug 25 '20 13:08 coveralls

Coverage Status

Coverage remained the same at 98.678% when pulling e71897c6cfbf103fd03d47c9c958cce694d9c8bf on sposs:master into 85546030f1ab9c216d806dc72d3bcd5c16390162 on maxtepkeev:master.

coveralls avatar Aug 25 '20 13:08 coveralls

Hi @sposs

It took me a while to reply... Sorry about that and thanks for raising this issue, the problem was actually way more serious as we were raising the exception for all attributes that actually exist, but their value was set to None, so this PR wasn't enough and we had to make a global fix (0de5689ef5891c1be263c0b3deb8b03966a9c5bd) which will work for all resources.

maxtepkeev avatar Dec 30 '22 18:12 maxtepkeev