react-native-spinkit icon indicating copy to clipboard operation
react-native-spinkit copied to clipboard

Published 20 hours ago • verified publisher icon maxs15

Where is FadingCircle in android?

Open seanadkinson opened this issue 8 years ago • 5 comments
trafficstars

Noticed FadingCircle isn't implemented in android... source code only handles FadingCircleAlt. Is that an oversight? If so, I'll send a PR. Thanks

seanadkinson avatar Aug 14 '17 23:08 seanadkinson

Weird, should be working. Not showing up if you try on the Example app ?

maxs15 avatar Aug 15 '17 13:08 maxs15

Didn't open the example app, but you can see in the source code that its not handled:

https://github.com/maxs15/react-native-spinkit/blob/6a53f5be6e0ff630d194c7174a8fba680b058186/android/src/main/java/com/react/rnspinkit/RNSpinkitView.java#L57

seanadkinson avatar Aug 15 '17 18:08 seanadkinson

You're right ! You could send a PR, I'll merge it, thanks @seanadkinson

maxs15 avatar Aug 16 '17 13:08 maxs15

Hi, I'm trying a Spinner with 'FadingCircle' as type, works on iOS but on Android shows only the square spinner. Is this related?

jjercx avatar Jun 08 '18 05:06 jjercx

Yep, it's still broken on android 😃

xeroxoid avatar Dec 06 '18 18:12 xeroxoid