Max Rothman
Max Rothman
Interesting, whats's an example of push notification subscriptions resulting from a user interaction? I'm not sure I understand how that would work. My use case is that I'm using silent...
Having the results be numeric (1 and 0 instead of true and false) is desirable IMO, I think that having boolean results would drastically change the semantics of `eq`, and...
@pe-ro > D.. al This seems like it's going to grow into a larger discussion, I've split that discussion out into https://github.com/music-encoding/music-encoding/issues/1643.
> While `` and `` are mentioned in both places, their use is explained only in section 2.1.2.2. They're just mentioned in passing in 2.2.1. The focus in this section...
It looks like this PR is still waiting on a second reviewer to sign off. Was there something I'm supposed to be doing to get that going, or is it...
Thanks for the review! I took care of the low-hanging fruit, I'll come back around to the more involved comments sometime this week hopefully.
@musicEnfanthen I think I've addressed all the comments you left in your last review in either comments or changes. Let me know if I missed anything!
Hi @musicEnfanthen, it looks like this branch has ended up conflicting with develop. I'd prefer to only have to do conflict resolution once, so would you mind giving me a...
Thanks for your help resolving that conflict. I've addressed the two comments you made recently, if I'm not mistaken then the last remaining issue is about the naming of the...
Do you mean https://github.com/music-encoding/music-encoding/pull/1638#discussion_r1966747370? As far as I can tell, https://github.com/music-encoding/music-encoding/pull/1638#discussion_r1966745982 is resolved.