F-Droid can't build

[licaon-kter]

...as the APK is not reproducible: https://monitor.f-droid.org/builds/log/com.maxrave.simpmusic/9#site-footer

My local APK: com.maxrave.simpmusic_9.apk.zip (remove .ZIP from filename)

Upstream APK: https://github.com/maxrave-dev/SimpMusic/releases/tag/v0.1.3-beta

Diff log: simp1.log

@maxrave-dev are you sure the APK you've uploaded is built from 452239aabe6c920bc4b2cec83112fcff57b3c11f ?

fyi @linsui @obfusk

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/50fe3776b5228a1b409f641085f7ef90dc1e3412

[maxrave-dev]

I checked Fdroid logs and I saw this Why in 452239a commit, I removed PersistentStorage.kt class but this appearing in the logs?

[maxrave-dev]

@licaon-kter fdroid build a337f51e5a4c744c66bd4cc30fafda3bae4e7a34 commit instead 452239aabe6c920bc4b2cec83112fcff57b3c11f commit. But 452239aabe6c920bc4b2cec83112fcff57b3c11f is correct release commit

[linsui]

I guess you moved the tag but F-Droid doesn't update the commit automatically.

[maxrave-dev]

@linsui I had created a wrong release and I have recreated a new with same name tag. Sorry for this inconvenient

[linsui]

This is why reproducible build is good: if a wrong commit is used the build will fail. :)

[licaon-kter]

fdroid build https://github.com/maxrave-dev/SimpMusic/commit/a337f51e5a4c744c66bd4cc30fafda3bae4e7a34 commit instead

Correct... I've missed that. Then again retagging should not be taken lightly :)

Will retest asap

[licaon-kter]

Yup, tests ok: https://gitlab.com/fdroid/fdroiddata/-/commit/3d4f3ff3cd9ecce031bcbe0136bbc20e488f2fd3 :tada:

[maxrave-dev]

Thanks for fixing @licaon-kter @linsui

[licaon-kter]

@maxrave-dev do add the APKs for https://github.com/maxrave-dev/SimpMusic/releases/tag/v0.1.4-beta

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/5249534435#L641

[maxrave-dev]

@licaon-kter sorry for the wrong release tag. I removed it

[licaon-kter]

removed it then: https://gitlab.com/fdroid/fdroiddata/-/commit/0a8c80ad6f7ac6f39dbec5cf292234b2f643b7e1

[licaon-kter]

https://monitor.f-droid.org/builds/log/com.maxrave.simpmusic/13#site-footer line 446, not the same commit used for building? Why is the tooling version mismatched?

[maxrave-dev]

Is buildSytemVersion Gradle? I dont know why

[linsui]

Yes. You have updated it to 8.2.1 so we use 8.2.1. But you still use 8.1.

[maxrave-dev]

@linsui what do i need to fix this ?

[linsui]

How did you build the apk? If you use gradlew from your repo it should use the correct gradle version.

[licaon-kter]

fyi https://gitlab.com/fdroid/fdroiddata/-/commit/1a7fbe41f28bb05762a7a925906e1d3f9a3dfa2c

[maxrave-dev]

@linsui I updated the APK file from the release using Gradle 8.2.1 to build

[licaon-kter]

@maxrave-dev I'll test locally now

[licaon-kter]

A bit better but the JSON file diff is still there: simp13.log

[linsui]

It's a known issue, right? https://f-droid.org/docs/Reproducible_Builds/#aboutlibraries-gradle-plugin

[maxrave-dev]

It's a known issue, right? https://f-droid.org/docs/Reproducible_Builds/#aboutlibraries-gradle-plugin

Oh I see, I will recreate a new release with fix commit now

[linsui]

The timestamp is removed but the file is still different. Your json is minimized but our json is formatted.

[linsui]

The json in your repo is formatted. Why is it minimized in your apk? Maybe you can clean the cache and rebuild the apk.

[maxrave-dev]

I turn on pretty print and generate a new json, in commit https://github.com/maxrave-dev/SimpMusic/commit/0c3fcf9bf571edbf6f0a59451c862cefe0b7bba6

[linsui]

https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14048 Fixed, thanks!

[licaon-kter]

Thanks

[licaon-kter]

@maxrave-dev just a heads up, pls build APKs from the Tagged commit in the future,else this happens:

==== detail begin ====

verification of APK with copied signature failed

Comparing reference APK to APK with copied signature...

Unexpected diff output:

diff -r /tmp/tmp1j9l4e5w/unsigned_binaries_com.maxrave.simpmusic_17.binary/content/META-INF/version-control-info.textproto /tmp/tmp1j9l4e5w/_tmp_tmp1j9l4e5w_sigcp_com.maxrave.simpmusic_17/content/META-INF/version-control-info.textproto

4c4

<   revision: "6f9840d7cbfb1de045f8c951e44e6d7931419475"

---

>   revision: "fbadeeeaedd3cf71e8ec40ca1a34a9a9835cec8e"

Binary files /tmp/tmp1j9l4e5w/unsigned_binaries_com.maxrave.simpmusic_17.binary/content/assets/dexopt/baseline.prof and /tmp/tmp1j9l4e5w/_tmp_tmp1j9l4e5w_sigcp_com.maxrave.simpmusic_17/content/assets/dexopt/baseline.prof differ

Binary files /tmp/tmp1j9l4e5w/unsigned_binaries_com.maxrave.simpmusic_17.binary/content/classes4.dex and /tmp/tmp1j9l4e5w/_tmp_tmp1j9l4e5w_sigcp_com.maxrave.simpmusic_17/content/classes4.dex differ

==== detail end ====

Not sure why the APK has the "commithash" inside, but it is what it is. We see this in other apps too.

fixed in: https://gitlab.com/fdroid/fdroiddata/-/commit/9f97b9ea56c09dfb88ceb336ad5a1910b7ab7c34

[licaon-kter]

not fixed fully, diff log: simp17.log

looks like https://gitlab.com/fdroid/fdroiddata/-/issues/3138 so can you bump https://github.com/maxrave-dev/SimpMusic/blob/v0.2.1/app/build.gradle.kts#L74 to 1.5.11 and the rest to 1.9.23? ref: https://developer.android.com/jetpack/androidx/releases/compose-kotlin#pre-release_kotlin_compatibility

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/9f9bd9175ab198391f5cda27950ed09d0bfb90c7

[maxrave-dev]

@licaon-kter I changed and committed, so do i need to create a new release?