SimpMusic icon indicating copy to clipboard operation
SimpMusic copied to clipboard

F-Droid build failed

Open linsui opened this issue 3 months ago • 14 comments

How should we build the j2v8 lib in https://github.com/maxrave-dev/SharedModules/tree/20a353786ed9270cff1a4951060a61d4020dac7f/j2v8?

linsui avatar Oct 06 '25 06:10 linsui

@linsui I need to wait for SmartTube maintainer replying

maxrave-dev avatar Oct 06 '25 11:10 maxrave-dev

@linsui here sir

https://github.com/yuliskov/SharedModules/tree/master/j2v8

maxrave-dev avatar Oct 06 '25 11:10 maxrave-dev

Is it a fork of https://github.com/eclipsesource/J2V8? This lib is available in maven central so we can use it directly.

linsui avatar Oct 06 '25 14:10 linsui

I thought it's pretty difficult to build the native part in https://github.com/yuliskov/SharedModules/tree/master/j2v8/src/main/jniLibs.

linsui avatar Oct 06 '25 14:10 linsui

@linsui, does native libs also not supported by F-Droid?

yuliskov avatar Oct 06 '25 14:10 yuliskov

Is it a fork of eclipsesource/J2V8? This lib is available in maven central so we can use it directly.

Yes, but the official release won't run on Android 4. My fix will run on Android 4.

implementation 'com.eclipsesource.j2v8:j2v8:6.2.1@aar'

yuliskov avatar Oct 06 '25 14:10 yuliskov

does native libs also not supported by F-Droid too?

they are, if we build them or pulled them from a trusted maven repo

licaon-kter avatar Oct 06 '25 14:10 licaon-kter

I thought it's pretty difficult to build the native part in

Yup, almost impossible do this with any auto build system. I barely managed to do this manually. I guess, the most easier way to overcome the issue is to replace it with the maven central counterpart.

yuliskov avatar Oct 06 '25 14:10 yuliskov

Yep, I thought this work though it's a little ugly. :) An easier solution is replacing the fork with the original lib since Android 4 is not supported by SimpMusic anyway.

linsui avatar Oct 06 '25 15:10 linsui

@linsui Should we skip this version? I will notice that and remove all aar in the next release

maxrave-dev avatar Oct 07 '25 01:10 maxrave-dev

@yuliskov Thank you for taking the time

maxrave-dev avatar Oct 07 '25 01:10 maxrave-dev

@yuliskov Thank you for taking the time

no problem, can I post here witch llne need to be changed in order to f droid build will be successful?

yuliskov avatar Oct 07 '25 04:10 yuliskov

Thanks!

linsui avatar Oct 07 '25 06:10 linsui

@yuliskov

no problem, can I post here witch llne need to be changed in order to f droid build will be successful?

No bro, I notice F-droid skips this version, and I will replace the AAR with another Maven Central library tobe compatible with F-droid policy

maxrave-dev avatar Oct 08 '25 01:10 maxrave-dev