gatsby-starter-morning-dew icon indicating copy to clipboard operation
gatsby-starter-morning-dew copied to clipboard

Published 20 hours ago • verified publisher icon maxpou

Support embedding video

Open dHannasch opened this issue 4 years ago • 0 comments

This includes video support by default, with a demonstration page modeled on the image demonstration page. Interested?

Adding video support turned out to be a little fiddly due to interactions with the other plugins, so I thought it might be worth including doing it the "right" way directly in the starter.

I'm not sure how best to handle duplicating plugins between the gatsby-transformer-remark entry and gatsbyRemarkPlugins. https://github.com/gatsbyjs/gatsby/issues/15486 is theoretically resolved, but appears to not always be resolved for everyone (https://github.com/gatsbyjs/gatsby/issues/15486#issuecomment-619228024). We could probably remove the duplication (including both gatsby-remark-images and gatsby-remark-embed-video) but it might be worth keeping a few more months so that someone trying to use the starter doesn't get blindsided by an unforeseen leftover of https://github.com/gatsbyjs/gatsby/issues/15486

dHannasch avatar May 03 '20 19:05 dHannasch