docker-symfony icon indicating copy to clipboard operation
docker-symfony copied to clipboard

forced to use symfony.dev ?

Open yohancourbe opened this issue 7 years ago • 8 comments

I don't think it makes sense to force the use of symfony.dev. It's quite restrictive for example if you want to run multiple of this build on a server, you need to edit the config of each containers. In my opinion, the virtualhost filtering should be done by a reverse proxy, not by this container.

I would propose to

  1. rm /etc/nginx/site-available/default.conf and
  2. make symfony.conf default_server

if we want to keep this feature, it should be at least a parameter in .env

yohancourbe avatar Apr 13 '17 12:04 yohancourbe

UP

devDzign avatar Apr 26 '17 15:04 devDzign

I'm not sure this repo is still managed..

yohancourbe avatar Apr 26 '17 15:04 yohancourbe

@yohancourbe ah ok, thank you

devDzign avatar Apr 26 '17 16:04 devDzign

Hiya @devDzign @yohancourbe, This issue was already raise few month ago (see #6). Unfortunately, after some testing, I never find a way to do it properly. By 'properly', I mean without makesfiles&co. I want to keep this stack simple, stupid. If you got a good way to implement it, feel free to open a pull request! I'd be more than happy to approve this! Cheers.

@yohancourbe it is still maintained, I'm just running out of time theses days 😉

maxpou avatar Apr 26 '17 16:04 maxpou

Yesterday I was forced to change the domain name because Chrome is forcing .dev domains to https. I suggest to use symfony.localhost by default. More in here

luislard avatar Dec 22 '17 11:12 luislard

FYI this stack now uses symfony.local (see #90). HSTS isn't a problem anymore

maxpou avatar Jan 29 '18 14:01 maxpou

Great!

On Jan 29, 2018 3:31 PM, "Maxence Poutord" [email protected] wrote:

FYI this stack now uses symfony.local (see #90 https://github.com/maxpou/docker-symfony/pull/90). HSTS isn't a problem anymore

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maxpou/docker-symfony/issues/58#issuecomment-361262904, or mute the thread https://github.com/notifications/unsubscribe-auth/ARGfHw-Zw78JIM8sPO-35YvLXBoRM7E-ks5tPdZAgaJpZM4M8n1G .

luislard avatar Jan 29 '18 14:01 luislard

@yohancourbe assuming you run 2 complete instances of these docker-compose.yml how do you configure separately both ? I mapped port 3000 for first docker-compose on nginx and 3100 on the second but I get some sort of load balancing no matter the port, on a refresh response switches between first and second

hiromik avatar May 04 '18 13:05 hiromik