Max Katz
Max Katz
The calculation of gwstrain() is quite inefficient. There are a lot of MultiFab::derive and then MultiFab::multiply operations. (The calculation itself, once the source fields are available, should not be that...
The _prob_params script (and perhaps later on _cpp_parameters and the extern variables) should be switched to a key = value format so that we can more easily add fields in...
The gravitational acceleration (g, not phi) is most naturally expressed at cell edges rather than cell centers in the Poisson gravity formulation, and it is straightforward to express it at...
A new Athena++ paper (https://arxiv.org/abs/2012.01340v1) argues that when g has truncation error that is larger than roundoff (which is true for multigrid), we can correct the lack of momentum conservation...
Even though in principle Poisson gravity can be used in the places where we currently use monopole gravity, we use monopole gravity only in 1D spherical coordinates (and can use...
`update_sources_after_reflux` re-evaluates all source terms after a reflux on all levels. The logic is that the distribution of matter on the grid has changed, so the new-time source terms we...
After #760 and #762, we now have Microphysics and AMReX as submodules. We have chosen to commit them as static commits, so we pick a specific commit/tag and they are...
We should be able to merge the hydro source constructor for both MOL and CTU. If we pass dt = 0 to the CTU hydro source constructor, the code should...
Consider the algorithm for allow_small_energy == 0, which is the stricter version we should ideally enforce. First, it computes small_e = EOS(rho, small_temp). Then it checks if eint < small_e....
One of the main difficulties in writing unit tests (e.g. issue #404) is that we have one monolithic build target in Make.Castro. If we modularized this so that individual components...