node-cache-manager-sqlite icon indicating copy to clipboard operation
node-cache-manager-sqlite copied to clipboard

[Bug] `.set` and `.mset` works not correctly with cache-manager v5

Open Sadzurami opened this issue 1 year ago • 1 comments

cache-manager v5 changed ttl from milliseconds to seconds.

So, if we works with cache-manager v5, we already use ms by default. But here under the hood mset multiply provided ttl by 1000.

https://github.com/maxpert/node-cache-manager-sqlite/blob/36a1fe44a30b6af8d8c323c59e09fe81bde539d9/index.js#L171

Suggestion: drop multiplying, add cache-manager v5+ to peer-deeps and increase major version of package.

upd: looks like cache-manager v5 changed a lot since v4, at least they not use callbacks anymore, so requires a bit more work for update current package.

Sadzurami avatar Jan 04 '24 12:01 Sadzurami

I just looked at v5 it's essentially a rewrite. I would try to find cycles to rework everything, I am open to contributions in the mean time.

maxpert avatar Jan 04 '24 21:01 maxpert