Results 54 comments of Maxime Biais

@CodeForcer I haven't used it in a while, can you provide a test sample? I'll update the code soon

@CodeForcer can you check this PR? https://github.com/maxme/abi2solidity/pull/19 - it should solve some issues with Solidity 0.8+ There might still be some missing cases, I have to finish checking the documentation...

It's possible to add new exchanges (whatever country / currency). You can have a look at a simple implementation and do the same for another exchange/API, for example: https://github.com/maxme/bitcoin-arbitrage/blob/master/arbitrage/public_markets/_bitstamp.py

Hi thanks a lot for the patch. It breaks a lot of things but add some cool features ;) - I'll probably create an unstable branch for it

You are right USD is not necessarily involved, it was just easier to write it like that (call me lazy). I'm really busy these days, I keep the issue open.

Hey thank you @ryepdx :+1: - first time an issue reply brings me money ;) - BTW, you're right, documentation and testing are seriously lacking.

version `0.8.4` is not signed also I noticed tag naming inconsistency `v0.8.4`, `0.8.3`

We recently switched the project license. Aztec is now under the MPL v2.0. More info on this ticket: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1305 If this PR gets merged, the code will be under the...

We recently switched the project license. Aztec is now under the MPL v2.0. More info on this ticket: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1305 If this PR gets merged, the code will be under the...

We should have a unit test to reproduce that one - cc @rachelmcr