audeye icon indicating copy to clipboard operation
audeye copied to clipboard

consider symphonia in the future

Open m4b opened this issue 1 year ago • 2 comments

Hello,

First off, incredible project; this is just what i wanted; a simple cli waveform viewer. i get tired of opening and closing audacity over and over just to see what a waveform looks like, etc.

One minor issue is that this is harder to build on e.g., macos, etc., due to dependency on libsoundfile.

While not as robust, symphonia (https://github.com/pdeljanov/Symphonia/blob/master/symphonia/examples/getting-started.rs) may get you to a most of the way there pure to a rust solution. I suspect they will do a new release soon, which has even more codecs and containers, etc.

Anyway, thanks for the great project! also, one last thing, you're missing 4 channel containers, and there is a minor typo; simple patch is here:

--- a/src/render/metadata.rs
+++ b/src/render/metadata.rs
@@ -80,7 +80,8 @@ fn channel_layout_to_string(channels: usize) -> String {
     match channels {
         1 => "mono",
         2 => "stereo",
-        3 => "ambinosic 2.1",
+        3 => "ambisonic 2.1",
+        4 => "quadrophonic",
         5 => "ambisonic 5",
         6 => "ambisonic 5.1",
         7 => "ambisonic 7",

m4b avatar Feb 12 '24 01:02 m4b

Glad to hear it helps ! I'll try to look into it this weekend. I might not integrate Symphonia right now but good to know thanks (I'm a bit busy at the moment)

maxmarsc avatar Feb 19 '24 09:02 maxmarsc

@m4b The quadrophonic support has been added to v0.2.1

I haven't had time to check Symphonia yet (I'm really rusty with rust, no pun intended). It's going to take a bit more of my free time, but I'll let you know.

I just realized I didn't fixed the typo :joy: I guess it will be for the next version

maxmarsc avatar Feb 24 '24 14:02 maxmarsc