redux-oidc icon indicating copy to clipboard operation
redux-oidc copied to clipboard

Immutable issue

Open DzmitryBiruk opened this issue 5 years ago • 6 comments

Hi looks like something is broken with immutable after latest update.

Screen Shot 2019-11-06 at 5 51 09 PM

DzmitryBiruk avatar Nov 06 '19 14:11 DzmitryBiruk

yeah

i suggest to export a reducer-immutable factory

export function createReducerImmutable(Immutable);

so there is NO require("immutable");

salvoravida avatar Nov 06 '19 15:11 salvoravida

@salvoravida great idea, will fix this ASAP.

Since this is an API change, semver dictates the next release to be version 4 instead of 3.1.7. However, I will release a version 3.1.7 which will undo the previous change and then update to version 4.

maxmantz avatar Nov 06 '19 17:11 maxmantz

Published changes to v4.0.0-beta1. Please check if this resolves your issues.

maxmantz avatar Nov 10 '19 09:11 maxmantz

yeah all ok!

salvoravida avatar Nov 26 '19 00:11 salvoravida

I am still getting typescript compile errors when not using immutable: node_modules/redux-oidc/index.d.ts:3:31 - error TS2307: Cannot find module 'immutable'.

3 import { Map, fromJS } from "immutable";

Can the immutable version be broken out into a separate file or package entirely?

mwasplund avatar Mar 27 '20 22:03 mwasplund

This bug is still present. Immutable is removed from dependencies, but imported in declaration file, which produces this problem.

image

kamiljozwik avatar Sep 24 '20 06:09 kamiljozwik