maxlath

Results 279 comments of maxlath

Hi! So for the back-story, [this module was forked from isbn2 as I attempted to better understand how it was working](https://github.com/tadas-s/isbnjs/issues/17). It probably lost some perf optimizations on the way,...

Returning a class object with getters would be a breaking change I think: for instance, passing that object to `JSON.stringifiy` will ignore the getters. There might be other scenario were...

That could be nice, but would definitely be a breaking change, unless that behavior is activated by a flag.

Maybe such a feature could be a new function, such as `parseStrict`, or behind a flag: `parse(isbn, { strict: true })`. In both case, that would remove the problem of...

maybe as a postinstall script or something of this kind?

I wouldn't like it to be the default behaviour as that would: * make the startup much slower * add a dependency on isbn-international.org status * add a non-dev dependency...

I added [a CI action](https://github.com/inventaire/isbn3/blob/master/.github/workflows/auto_update_groups_data.yml) to auto-update groups data every 1st of the month: today was the first [auto-update](https://github.com/inventaire/isbn3/commit/058aa35)+[patch version publication](https://github.com/inventaire/isbn3/commit/d795fd7) triggered that way. This means that as long as...

The action was disabled for some reason I don't get, but now it's reactivated, and I manually ran (8afee59) and published (`v1.1.7`) an update

Could it be that in your shell environment, `$LANG` starts with `C`? That environment variable was checked to infer a preferred language in absence of an explicit config value, but...