mysql2postgres icon indicating copy to clipboard operation
mysql2postgres copied to clipboard

`count_for_pager` is broken for id fields that aren't integers

Open campbellr opened this issue 9 years ago • 1 comments

Table.has_id is used to determine whether or not to use MAX(id) vs COUNT(*) in count_for_pager, but this only works if the id field is an integer.

In my schema i have an id that is a text type representing a UUID, which makes count_for_pager always return 0.

I think it might be safer to only use MAX(id) if has_id is true and the id field is some sort of integer type

campbellr avatar Jun 22 '15 21:06 campbellr

Would you like to make a pull request?

paazmaya avatar Jul 22 '15 12:07 paazmaya