dovetailer icon indicating copy to clipboard operation
dovetailer copied to clipboard

Quotes deleted when empty

Open haleighkay opened this issue 7 years ago • 2 comments

There are cases where you might want an empty alt tag on an image, like for a spacer image. It’s best practice to have the alt attribute on all images, even if it’s empty, it’s better than none at all. And since it is blank, it's less annoying for screen readers to have nothing there than to say something like "blank spacer image" and less abrasive if the image doesn't load to not have actual alt text show up and thereby keep it as small as possible. The compiler is currently deleting said empty quotes, as seen below:

2836650129-screen shot 2017-03-14 at 11 22 01 am 2457946575-screen shot 2017-03-14 at 11 21 47 am

haleighkay avatar Mar 17 '17 16:03 haleighkay

I did some investigation, it's not coming from email-remove-unused-css dependency (just tested on v1.16.0), you can check it yourself on emailcomb.com with live code. It's some other dependency library causing this.

Can you guys confirm this bug is still happening? I don't want to assemble a dummy dovetailer project just to check. Cheers.

revelt avatar Apr 05 '17 10:04 revelt

@revelt sorry, i do think this is still an issue. i've been very busy the past few weeks, but i should be able to address this soon! and PRs are always welcome :)

maxlapides avatar Apr 05 '17 17:04 maxlapides