node-lastfmapi icon indicating copy to clipboard operation
node-lastfmapi copied to clipboard

update lastfm dependency version

Open Kikobeats opened this issue 10 years ago • 4 comments

Hey man, Why not update lastfm version? break the code?

:)

Kikobeats avatar Sep 03 '14 14:09 Kikobeats

Thanks for the info! I wasn't aware of the new release of lastfm. I will check it out and see if it would break anything. Unfortunately there are no automated tests (yet) so I will have to create them or test manually.

If you have some time and want to help out I'd be glad if you could try to upgrade the dependency and see if it still works.

maxkueng avatar Sep 05 '14 09:09 maxkueng

I create a little module for my framework that use this API and I have a little tests (only for check if works fine with the most important options):

https://github.com/sailorjs/sailor-module-lastfm

check test folder!

2014-09-05 11:19 GMT+02:00 Max Kueng [email protected]:

Thanks for the info! I wasn't aware of the new release of lastfm. I will check it out and see if it would break anything. Unfortunately there are no automated tests (yet) so I will have to create them or test manually.

If you have some time and want to help out I'd be glad if you could try to upgrade the dependency and see if it still works.

— Reply to this email directly or view it on GitHub https://github.com/maxkueng/node-lastfmapi/issues/3#issuecomment-54602564 .

Kikobeats avatar Sep 05 '14 09:09 Kikobeats

Thanks! Will check it out. Are there any important changes to lastfm that you need in your module? i.e. is it urgent?

maxkueng avatar Sep 05 '14 11:09 maxkueng

About this, I would like that all functions accept a object as parameter that follow the same pattern.

Check in the next link that I try to access passing and object and later, if fails, try to fix it: https://github.com/sailorjs/sailor-module-lastfm/blob/master/api/services/LastFMService.coffee#L23

:(

2014-09-05 13:27 GMT+02:00 Max Kueng [email protected]:

Thanks! Will check it out. Are there any important changes to lastfm that you need in your module? i.e. is it urgent?

— Reply to this email directly or view it on GitHub https://github.com/maxkueng/node-lastfmapi/issues/3#issuecomment-54613778 .

Kikobeats avatar Sep 05 '14 13:09 Kikobeats