react-native-ultimate-config icon indicating copy to clipboard operation
react-native-ultimate-config copied to clipboard

Fix objective c import in api.md

Open thorgas opened this issue 1 year ago • 4 comments

hi @maxkomarychev, thank you very much for this library! Not sure if something in my setup is wrong, but in order to use the env variables in Objective-c I had to change the import from your docs (https://github.com/maxkomarychev/react-native-ultimate-config/blob/master/docs/api.md#objective-c) to #import <react_native_ultimate_config/ConfigValues.h>

thorgas avatar Jun 08 '23 20:06 thorgas

Hi, I have not experienced this. Could you please share more information about your setup? (version of Xcode, iOS deployment target, whether swift is used or no etc).

Thanks!

maxkomarychev avatar Sep 01 '23 08:09 maxkomarychev

Hi, my Xcode version is Version 14.3.1 (14E300c), IPHONEOS_DEPLOYMENT_TARGET = 14.0, we are using a bridging header and we have a module integrated via spm via Frameworks, Libraries, and embedded Content in Xcode under TARGETS -> General. RN version is 0.71.0. Above mentioned import happens in AppDelegate.mm

thorgas avatar Sep 04 '23 10:09 thorgas

Hi @thorgas , thanks for your PR, that's really helpful for me!

@maxkomarychev this PR is fix for the issue https://github.com/maxkomarychev/react-native-ultimate-config/issues/144

dkulakov avatar Feb 24 '24 10:02 dkulakov

Thanks @thorgas for your PR!

alexkev avatar Apr 30 '24 20:04 alexkev