Pe/fix

Open shamoons opened this issue 5 years ago • 6 comments

Dec 11 '20 17:12 shamoons

There was an error that this fixes @maxjcohen

Dec 11 '20 17:12 shamoons

Hi, if you're talking about the default value of pe_period, I would like to keep it as is. It's well documented too. Do tell me if there is something else I haven't seen here.

Dec 15 '20 15:12 maxjcohen

I'll update it to keep the default period. The actual error is caused here: https://github.com/maxjcohen/transformer/blob/master/tst/transformer.py#L129

so I'll come up with another solution and update this PR accordingly

Dec 15 '20 15:12 shamoons

I see, I'll let you work on it, and see if I can find a alternative later this week.

Dec 15 '20 15:12 maxjcohen

Give me a day or 2 if you can and I'll have something

Dec 17 '20 14:12 shamoons

@maxjcohen check the update. This should work now

Dec 18 '20 18:12 shamoons