Maxim Masiutin comments

Results 105 comments of


                                            Maxim Masiutin

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

> not a bug, just a consideration of what to optimize for. Appearance of idle workers just because the task is split by too few workers due to high batches...

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

See attached screenshot: 2338 games per batch for 16 cores, 3496 games for 24 cores -- that's just too much for 10+0.1s. ![cores](https://user-images.githubusercontent.com/25011752/234821823-6ee65e67-2e8d-40e2-be94-21450024d12f.png)

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

Can you make a config option to set maximum amount of games per batch to mitigate this bug that causes idle workers because of too large batches? I have batches...

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

Fixed by #1659

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

> SPRT I have an SPSA test (not an SPRT) with 3000000 games, and the workers are "greedy", so they took all the games and I cannot add more workers...

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

> Wouldn't this be solved by the PR that increases the maximum number of games for an SPRT test? For an SPSA test, I cannot increase the number of games....

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

This is not a corner case. I am now experiencing such a message the whole day today ("No tasks available at this time, waiting..."): ``` Current time is 2024-07-06 17:12:24.609797+00:00...

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

The current workers are too "greedy". They "reserve" too much work so that they do not leave work to the other workers.

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

There is now at least the worker e85c97d3 that does not receive tasks due to a bug in batch size calculation, so the initial bug report submitted on Apr 27,...

Bug in batch size calculation introduced recently: when there are many workers but few tasks, the task is not properly split between the workers which results in idle workers

Another solution would be by the Fishtest server to count idle workers and display the number of idle workers alongside the total number of workers. Then, if the notice number...