notification-bundle icon indicating copy to clipboard operation
notification-bundle copied to clipboard

Problem with installed version of Twig 3.0

Open garethfoxtrot opened this issue 4 years ago • 3 comments

I'm trying install notification bundle on Symfony 4.4 with Twig 3.0.4 but problem is following: "Argument 3 passed to Mgilet\NotificationBundle\Twig\NotificationExtension::__construct() must be an instance of Twig_Environment".

I found the solution in construct we need change "\Twig_Environment $twig" on "\Twig\Environment $twig", because \Twig_Environment is deprecated.

"Using the "Twig_Environment" class is deprecated since Twig version 2.7, use "Twig\Environment" instead."

garethfoxtrot avatar Aug 01 '20 12:08 garethfoxtrot

Hi @garethfoxtrot, could you submit a PR for this change ? Thanks in advance

maximilienGilet avatar Jan 07 '21 08:01 maximilienGilet

I've added PR here https://github.com/maximilienGilet/notification-bundle/pull/83

thinkawitch avatar Apr 16 '21 15:04 thinkawitch

I'm so sorry, unfortunalety I forgot add PR it's was a few month ago.

pt., 16 kwi 2021 o 17:00 Andrew @.***> napisał(a):

I've added PR here #83 https://github.com/maximilienGilet/notification-bundle/pull/83

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maximilienGilet/notification-bundle/issues/80#issuecomment-821238233, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLNCNFCPCWKUFJLGCL2INDTJBGIJANCNFSM4PRWPGNA .

garethfoxtrot avatar Apr 16 '21 21:04 garethfoxtrot