digital-garden-jekyll-template icon indicating copy to clipboard operation
digital-garden-jekyll-template copied to clipboard

Not Working with Jekyll CommonMark

Open xplosionmind opened this issue 4 years ago • 4 comments

The bi-directional links generator doesn't parse links when jekyll-commonmark is used.

xplosionmind avatar Jan 09 '21 19:01 xplosionmind

Hi @xplosionmind, I switched to Commonmark and it's working for me. Hope this helps:

I used the Github Pages version because it supports Github Flavored Markdown, which helps keep things consistent with the formatting. Plus it enables Github-flavored tables and works with Obsidian!

meewgumi avatar May 30 '21 04:05 meewgumi

Thanks folks. What do we think about switching the template to Commonmark by default? This way it would offer a standardized experience for the majority of use cases.

maximevaillancourt avatar May 31 '21 11:05 maximevaillancourt

@maximevaillancourt I like Commonmark for most cases, but I found one interesting drawback: You can no longer use {: .internal-link} notation to add classes or IDs. It looks like this is a Kramdown feature. It doesn't bother me too much since I'm OK switching to HTML classes for this use case.. but if someone has a lot of these links in their site they'll have to go manually update them after fetching upstream

meewgumi avatar May 31 '21 21:05 meewgumi

The main issue presented by Commonmark, in my opinion, is definitely the lack of auto-generation of ids for headings.

See this related issue.

xplosionmind avatar Jun 08 '21 22:06 xplosionmind