ngx-smart-modal
ngx-smart-modal copied to clipboard
maximelafarie
unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11.
unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11
Before including this lib to my project I decided to check compatibility with ng 10 and it works fine... anyway inside stackblitz-sandbox.
I am getting error with angular 11 and "ngx-smart-modal": "^7.4.1" during ng build:
Compiling TypeScript sources through NGC
ERROR: projects/ui-lib/node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:8:23 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).
8 static forRoot(): ModuleWithProviders;
I am getting error with angular 11 and "ngx-smart-modal": "^7.4.1" during ng build:
Compiling TypeScript sources through NGC ERROR: projects/ui-lib/node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:8:23 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s). 8 static forRoot(): ModuleWithProviders;
Hello, we had same error because our postinstall hook failed in deployment pipeline. This command contained ngcc. So first I suggest you to check if you use ngcc correctly (https://indepth.dev/posts/1259/angular-compatability-compiler) and it's running without warning in you environment (https://stackoverflow.com/questions/18136746/npm-install-failed-with-cannot-run-in-wd). Now using Angular 11.1.1 and it works fine after update and ngcc fix.
A dedicated version for Angular v10/v11 will be released, so I'm adding this issue to the next major release. Thank you all for your comments.
🖖
Of course a fully compatible v11 version is desired, but I have been using the package as is under v11 and have not encountered any problems at all.
