ngx-smart-modal icon indicating copy to clipboard operation
ngx-smart-modal copied to clipboard

Dialog is not always shown on top of another dialog

Open be-ndee opened this issue 5 years ago • 4 comments

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior I have two dialogs. Dialog A and dialog B. I call dialogA.open(true) in dialog A. Then I close dialog A with dialogA.close(). Then I open dialog B with dialogB.open(true). When dialog B is opened, I open dialog A aswell with dialogA.open(true). Dialog A will then be shown behind dialog B.

Expected behavior Dialog A should be shown on top dialog B, not behind it.

Reproduction of the problem Important is, that the dialog, which should be shown on top of another dialog, must have been opened and closed before the dialog underneath it. So you have to open and close dialog A, then open dialog B and open dialog A.

What is the motivation / use case for changing the behavior? It's a bug :-D

Please tell us about your environment:

  • Smart Modal version: 7.3.0

  • Angular version: 8.2.14

  • Browser: all

  • Language: all

be-ndee avatar Mar 09 '20 09:03 be-ndee

I already created a pull request, because I found the bug: #274

be-ndee avatar Mar 09 '20 09:03 be-ndee

Hi @be-ndee! Sorry for the late answer. Thank you very much for your PR, can you just please create a new one with your code rebased on the master branch? Since we updated our PR-check rules, previous PRs seem a bit messy. I'll merge it as soon as you created the new one. (I'll close the #274 after that). 🖖

maximelafarie avatar Jun 19 '20 10:06 maximelafarie

Thank you, I've created a new PR #290

be-ndee avatar Jun 22 '20 09:06 be-ndee

@maximelafarie can this fix (and others) added to version 7?

pepas24 avatar Sep 14 '23 21:09 pepas24