Maxime BORGES
Maxime BORGES
> So would it be fair to say that RTS and CTS pins should be declared as type parameters but should be optional when passed to the serial interface? If...
I think the way the L4 HAL is doing it might be the way to go. This means that one would have to re-configure the UART driver with the right...
Oh also, the implementation from the esp32-hal could be a nice source of inspiration: https://github.com/esp-rs/esp-hal/blob/main/esp-hal-common/src/uart.rs
> The specification for stm32f7xx devices says that the same UART can be used with multiple TX and RX pins. The code matches that. For example, UART4 can use PA0...
> Please let me know what you think of the approach. Did you have a look at the STM32L1 implementation? In particular the bit here: https://github.com/stm32-rs/stm32l4xx-hal/blob/master/src/serial.rs#L1154-L1177, and how you can...
> By the way, I have added this as in-code comments, but should say it in here too: it seems UART8 was missing from the original code. Shall I add...
> Also, in my already rather large PR there is a controversial change: I have renamed template parameters USART to just U in several places. This was to free up...
> The implementation in STM32L1 looks interesting. I think I understand most of it but I am not sure the solution is optimal either. I agree that it's not optimal;...