Maxime

Results 51 issues of Maxime

This PR aims to fix https://github.com/cloudnc/ngx-sub-form/issues/161 but unfortunately while it seems to be working just fine on the component hosting the FormArray, I've noticed that the error is not broadcasted...

scope: lib
PR-action: discuss
PR-state: WIP
type: bug/fix
workaround: none

# Context This is taking over https://github.com/cloudnc/ngx-sub-form/issues/118 as this issue much bigger than just for adding new values into `FormArrays`. Having a look into https://github.com/cloudnc/ngx-sub-form/pull/146 and the stricter settings, I...

scope: lib
effort-2: hours
state: needs design
type: RFC/discussion/question

In both v5: https://github.com/cloudnc/ngx-sub-form/blob/b8890b887dd1a49b6caee7e3be7be61ebca74aa7/projects/ngx-sub-form/src/lib/ngx-root-form.component.ts#L46 And v6: https://github.com/cloudnc/ngx-sub-form/blob/274420a982b6b7aaa3b7ae449521b4f9f1eeb8f9/projects/ngx-sub-form/src/lib/ngx-sub-form.ts#L151-L167 We do a check on the equality between the previous value of the form and the current one. If we do not bind...

Making the input (of a root form component) or the value (set on a sub form component) be a partial of the interface would open new possibilities such as: -...

type: RFC/discussion/question

When creating a sub form we are strict and expect no missing properties, nor additional ones. This lets us behind the scenes use `setValue` instead of `patchValue` which wouldn't be...

scope: lib
effort-1: minutes
flag: breaking change
type: feature

This closes cloudnc/ngx-sub-form#91

scope: lib
type: feature

When dealing with `FormArray`, I believe a common use case is to click a button to add an empty entry in the array and later on from the UI fill...

scope: lib
effort-1: minutes
state: needs design
type: RFC/discussion/question
workaround-1: obvious

We definitely miss some E2E and unit tests. Once they're here, Travis would be a nice fit for CI. Would also be useful to enforce lint + prettier checks!

module: Frontend
type: Chore

E2E tests are definitely missing here and I ended up breaking the export as CSV function after a library update which removes an rxjs operator I was using... [Cypress](https://docs.cypress.io/guides/overview/why-cypress.html) seems...

module: Frontend