Maxime

Results 194 comments of Maxime

I think it should be ```ts export type NullableProps = { [P in keyof T]: T[P] | null }; protected createFormArrayControl( key: ArrayPropertyKey | undefined, value: NullableProps, ): FormControl ```...

> @maxime1992 I think I've understood now what you were working to achieve but I realised that my thinking was too complex to explain in a MR comment, so instead...

I ran into cases where I wish it was coming from `getRawValue` but `value` does reflect what `formGroupe.value` would return except that it's recursive. Maybe we could add a `formGroupRawValues`...

_Reporting back some information I discussed with @zakhenry to keep track of it there :)_ Forms in general (without Angular, frameworks, libraries or even JS) have 2 things available to...

:point_up: I've gathered some of my thoughts on the issue linked above (CF [comment](https://github.com/angular/angular/issues/11447#issuecomment-584740317)). Writing things down helped me clean up my mind and **I don't think** that waiting for...

Discussed with @zakhenry: We should implement the solution above (to "hide" the raw value) and have a function which is recursively going through the object to search for raw values...

> For this reason i would prefer a more configurative solution. @danielhartig have you read https://github.com/cloudnc/ngx-sub-form/issues/103#issuecomment-583022642 ? It's not like we're against a better solution it's just that we haven't...

The problem with both of these solutions are that it'll affect everything downstream and as sub forms are composable you may end up with unwanted and non default behaviors. By...

From what I understand that change doesn't need any work on ngx-sub-form side, does it? If it's something quite easy to draft feel free to have a first stab at...

Hi @anschm, thanks for taking a look at it. Appreciated! Unfortunately I don't think it's good enough to end up in ngx-sub-form. That said, I think I may have an...