Maxime

Results 194 comments of Maxime

Sounds good, nice one. Feels like this might need an e2e test to cover what wasn't if you feel like it :pray:

Hello, I'll take the time now. Having a look

> I think we have another issue with enable/disable. It emits the form value as often we have sub forms. So we should emit a value only its changed. Maybe...

> We should bring this into version 6.x.x. and 5.3.x. I know it'd be nice but realistically I'm not sure we need it. We've got a very limited bandwidth and...

FYI @anschm https://github.com/cloudnc/ngx-sub-form/pull/260

> Any update on that? Sorry for pushing that, but this blocks a lot of projects on our side. I think I may not have been clear enough on that....

@dscoblen thanks for the kind words, we appreciate :smile:! @cbleu also thanks for the detailed comment :ok_hand:! > we spend lot of time to search the best (less worse ;)...

@MonsieurMan thanks for the details on the project and how ngx-sub-form helped you solved them! Can you create an issue for the thing you're struggling with? I'll try to help...

@anschm this issue is only for people to share their experience with ngx-sub-form so I'm not going to say much about the ETA of the final version for the current...

Just had a random thought: If we do this before broadcasting the value up we probably want to check that the form is not disabled