Maxime
Interesting. If you open the devtool and click on the red line in cypress with the error, you'll get in the console of the browser the exact diff and why...
Can you push where you're at currently and raise a PR even as WIP? I'll try to take a look locally so I better grasp what's going on there :)
Can you fork and raise a PR instead please? :) (and nice one for the fix, thanks for looking into it!)
I've got a bunch of work to focus on so not sure I'll be able to before end of week I do keep it in mind and will try to...
Hi, thanks for having a go at it! In my opinion, this isn't good enough unfortunately. I think it could lead to unexpected situations where you set a sub form...
Woops looks like we've forgotten about that one :o If anyone is keen to look into it please let me know.
@ChrTall yes that was done on purpose. You can see the code here: https://github.com/cloudnc/ngx-sub-form/blob/4ab93f6e83b993d90ce4f7c4fc8e56c9b5b3ce00/projects/ngx-sub-form/src/lib/deprecated/ngx-root-form.component.ts#L70-L72 The reason being, if nothing changes why would you save it again, maybe just discard the...
Yup I think this relates to a known issue with Angular on which I gave my input here: https://github.com/angular/angular/issues/11447#issuecomment-584740317 I think your best move for now is to either simply...
This LGTM but I'm also afraid I might be missing something. I'm pretty sure that we did set to off for a good reason and either it may be dangerous...
@ntziolis I believe this will be solved by the rewrite here: https://github.com/cloudnc/ngx-sub-form/pull/176 When you have some time please have a look and close this one if it's ok as the...