Maxime

Results 213 comments of Maxime

Hey guys I'm stuck too because of that (need of `routerLink` and `fragment`). Has anyone found a good workaround?

I just investigated this and found the root cause. This is because for the errors we create an array representing the errors for each entry of the array. So it...

@agarzas I've tried to make a fix and got it partially working: https://github.com/cloudnc/ngx-sub-form/pull/199 Unfortunately I found an issue and I'm not able to merge just yet. This is not on...

> It works as an workaround, but is really ugly. It would be great to have this fixed soon I don't have time to look into this. Please raise a...

Thanks for the investigation. It's unfortunately a piece of code where I wished we put a comment next to it because I really can't remember why there's emit event false....

You need to serve the app ``` yarn demo:start ``` and launch the e2e tests in parallel ``` yarn demo:test:e2e:watch ```

> It seems your tests are not stable because there are a lot AssertionErrors. Please check the e2e tests by your self. I don't know whats wrong with the tests....

@anschm maybe try this branch, I just made a PR to upgrade cypress from v4 to v10, hopefully it may help with the tests being flaky on your side? https://github.com/cloudnc/ngx-sub-form/pull/258/

> whats happening if you run the tests with my change? Apparently nested errors are broken: ![image](https://user-images.githubusercontent.com/4950209/173044445-f100ae4b-6ce6-4fc6-931d-04362fae4bbb.png)

I'm afraid not, I haven't spent any time on this. After doing that I made a few MR to update ngx sub form to latest angular, cypress and remove the...