aiohttp-apispec icon indicating copy to clipboard operation
aiohttp-apispec copied to clipboard

In webargs 6, use_args will accept a single location

Open lafrech opened this issue 4 years ago • 6 comments

Hi.

Just a friendly heads up about this change coming in the next major webargs version.

https://github.com/marshmallow-code/webargs/pull/420

Do you foresee any issue with this?

lafrech avatar Dec 22 '19 21:12 lafrech

@lafrech, hi!

Thank you for this information!

I will try to make needed changes as soon as possible to make it compatible with webargs 6.

maximdanilchenko avatar Dec 23 '19 09:12 maximdanilchenko

Hi.

I have an issue using 'webargs==6.1.0' and validation_middleware. It works with 'webargs==5.5.3'

python3.7/site-packages/aiohttp_apispec/middlewares.py", line 34, in validation_middleware schema["schema"], request, locations=schema["locations"] TypeError: parse() got an unexpected keyword argument 'locations'

I can take a look a bit later and make PR.

rch9 avatar Jun 05 '20 12:06 rch9

This lib is not compatible with webargs 6 (yet ?).

https://github.com/maximdanilchenko/aiohttp-apispec/blob/98324c052f46b478b7fb94ebc6c9c70ae39cecb7/requirements.txt#L3

lafrech avatar Jun 05 '20 12:06 lafrech

@rch9 it would be great if you can take a look!

maximdanilchenko avatar Jun 05 '20 13:06 maximdanilchenko

https://github.com/marshmallow-code/webargs/blob/25475ed158a45a9963f401edc71c9ac5256706f7/src/webargs/asyncparser.py#L30

yarula avatar Aug 15 '20 19:08 yarula

@maximdanilchenko Can be closed Fixed by https://github.com/maximdanilchenko/aiohttp-apispec/pull/112

kiforchuk avatar Feb 03 '22 18:02 kiforchuk