maxi-blocks icon indicating copy to clipboard operation
maxi-blocks copied to clipboard

Implement `onChangeInline` on ANC

Open Naaaaiix opened this issue 3 years ago • 4 comments

As @Fybex correctly shared on chat, the new attributes saving mechanism has a side effect where a creator, dragging and displacing a range input, can pass throw its previous attribute value, removing it (as the new saving mechanism removes it when they coincide). After talking about, we both agreed that applying the same system as on ColorControl based on onChangeInline that changes the styles inline while the value is still not defined, will fix this glitch.

Have to say that the idea of implementing this methodology in ANC was talked long ago and was waiting to be implemented as it was causing some bad UX while dragging the range and the rendering answer was a lagging. This way we fix 2 issues at same time 👍

Naaaaiix avatar Oct 20 '22 13:10 Naaaaiix

Isn't it the same as #4150?

myroslavve avatar Jan 12 '23 17:01 myroslavve

Isn't it the same as #4150?

Not exactly the same: this issue is for ANC, #4150 is for the range inside ANC. So #4150 will fix a part of this issue, but won't fulfil it 👍

Naaaaiix avatar Jan 13 '23 08:01 Naaaaiix

Does it make sense to do both at the same time?

kyrapieterse avatar Jan 14 '23 11:01 kyrapieterse

Does it make sense to do both at the same time?

Complete sense 👍

Naaaaiix avatar Jan 16 '23 09:01 Naaaaiix