hickory icon indicating copy to clipboard operation
hickory copied to clipboard

[Bug] hickory confirms killed even on typo

Open maxhumber opened this issue 4 years ago • 8 comments

hickory kill foo.oy

Killed foo.oy

Definitely wrong...

maxhumber avatar Oct 07 '20 13:10 maxhumber

I can work on this

Vipul-Bajaj avatar Oct 07 '20 17:10 Vipul-Bajaj

All yours! Thanks :)

maxhumber avatar Oct 07 '20 18:10 maxhumber

Thus the following message looks good if script/id not found. "Kill failed. foo.oy not found."

Vipul-Bajaj avatar Oct 08 '20 15:10 Vipul-Bajaj

I'll try to take a look tomorrow! But thanks, @Vipul-Bajaj.

Want to take a stab at #5? This might be a good guide: https://stackoverflow.com/a/17064509/3731467

Need all confirmation messages, warnings, and failures to be coloured on console print

maxhumber avatar Oct 08 '20 17:10 maxhumber

I'll try to take a look tomorrow! But thanks, @Vipul-Bajaj. - Np :)

Want to take a stab at #5? This might be a good guide: https://stackoverflow.com/a/17064509/3731467 - busy with somethings, if I get some time will let u know

Need all confirmation messages, warnings, and failures to be coloured on console print

Vipul-Bajaj avatar Oct 08 '20 17:10 Vipul-Bajaj

@maxhumber Did u had a look into the PR?

Vipul-Bajaj avatar Oct 13 '20 14:10 Vipul-Bajaj

Looks good! but could you be sure to run https://pypi.org/project/black/ and mypy?

maxhumber avatar Oct 13 '20 15:10 maxhumber

I ran both black and mypy and have committed the changes. Do let me know if anything else is required.

Vipul-Bajaj avatar Oct 13 '20 16:10 Vipul-Bajaj