ansible-collection-smallstep
ansible-collection-smallstep copied to clipboard
maxhoesel-ansible
Add `step_certificate` role, supporting multiple provisioners
Adding step_certificate as a new role that can accommodate all different types of provisioners.
For the current implementation, only supports:
- ACME
- JWK If the requested provisioner is not supported, the role will fail with appropriate message.
If this role is adopted, I suggest we deprecate step_acme_cert, and will resolve #127.
NOTE - this PR is a DRAFT, and I'm soliciting feedback.
I'm not sure the tests will pass yet. I don't really expect them to pass, but even if they do, it's only because I copied the step_acme_cert and didn't modify the testing yet. Again, looking for feedback on the approach before putting in more effort.
Looks good! I'd be happy to merge this once the tests have been adjusted to cover both provisioners 👍
@maxhoesel and @eengstrom are you guys still looking to add this? I think this would be hugely helpful to support JWK provisioners. Thanks.
@salekseev -- Yes, at least I am still interested. I'm still using a fork I have, but it's sorely out of date with respect @maxhoesel 's mainline code base, but have need to rebase anyway. I'm open to more help to develop the testing that Max (rightly) wants, if you have inclination.
I would also still be happy to merge this, and I might be able to help out with the tests as well. Unfortunately I haven't had a lot of time to work on this collection recently, and that's unlikely to change for about another month or so. I'd be happy to have a go at this once things calm down for me though!