ghactions

ghactions copied to clipboard

also seems dumb to copy this from the docs

maxheld83

maybe the structure of the syntax is already stored somewhere, maybe in the runner or some other open source package by github. It seems a bit dumb to just copy/paste...

maxheld83

this ain't right anymore, correct way is: ``` if (!identical(Sys.getenv("GITHUB_ACTIONS"), "true")) { return(invisible(TRUE)) } else { return(invisible(FALSE)) } ```

maxheld83

currently in https://github.com/ropensci/tic/pull/250/commits/6feb19b54a083a1a547827390aba792faef02a53#diff-7ce4230c601038ab50cc3bdacbcfdab4 cc @pat-s

maxheld83

point to / consider code-duplication with pre-commit hooks

1

https://github.com/lorenzwalthert/pre-commit-hooks

maxheld83

code coverage is not uploaded

2

maxheld83

Sometimes deploys even of static assets may silently fail (looking at you, GitHub Pages), and it might be nice to have an action that tests this quickly.

maxheld83

this is an issue with pkgdown, I think -- it will not create a ghpages branch if it does not already exist.

maxheld83

occurs with `r-lib/actions` tidyverse default.

maxheld83

maxheld83