vscode-discord icon indicating copy to clipboard operation
vscode-discord copied to clipboard

Closing Visual Studio Code does not remove the RPC information

Open justalemon opened this issue 7 years ago • 9 comments

Even if you close VS Code, you still will see information about the file and folder open. Information about Visual Studio Code is still on Discord

justalemon avatar Nov 22 '17 06:11 justalemon

it's an issue directly with Discord. just reload it. (Ctrl+R)

fratik avatar Nov 22 '17 16:11 fratik

It's because the activity is not reset when VScode is closing, I'm looking for an event to handle it.

maxerbox avatar Nov 22 '17 17:11 maxerbox

With the disposable client, the Rich Presence is reset when Visual Studio Code is closed, but it's still displaying "Playing Visual Studio Code". To fix it, you need to add Visual Studio Code as a game.

maxerbox avatar Nov 22 '17 18:11 maxerbox

Discord says that is recomendable to send a shudown signal when the app closes, so the RPC server removes the status.

justalemon avatar Nov 27 '17 13:11 justalemon

@justalemon May you have some docs about sending a shutdown signal to discord, it could be helpfull

maxerbox avatar Nov 28 '17 17:11 maxerbox

@maxerbox https://discordapp.com/developers/docs/rich-presence/how-to image

justalemon avatar Nov 28 '17 17:11 justalemon

Yeah, it is calling the static void Destroy(BaseConnection*&); function,

https://github.com/discordapp/discord-rpc/blob/master/src/discord-rpc.cpp#L312

https://github.com/discordapp/discord-rpc/blob/master/src/connection_win.cpp#L66

It cannot be done with the discord-rpc server.

maxerbox avatar Nov 28 '17 17:11 maxerbox

I hope it is fixed now ^^

maxerbox avatar Dec 04 '17 19:12 maxerbox

Hate to dig up such an old issue, but the problem is still there.

Alexejhero avatar Jan 26 '20 20:01 Alexejhero