tplay icon indicating copy to clipboard operation
tplay copied to clipboard

[BUG] Nix package not installable

Open bauersimon opened this issue 9 months ago • 3 comments

Describe the bug Compilation error when using 24.11 nix package. (inside WSL2)

To Reproduce Steps to reproduce the behavior:

# tplay.nix
let
  nixpkgs = fetchTarball "https://github.com/NixOS/nixpkgs/tarball/24.11";
  pkgs = import nixpkgs { config = {}; overlays = []; };
in
pkgs.mkShell {
  packages = with pkgs; [
    tplay
  ];
}

nix-shell tplay.nix

Log/Error:

nix_install.log

Expected behavior Clean installation.

Desktop (please complete the following information):

  • OS: Ubuntu 24.04.1 (WSL v2.3.26.0)
  • nix --version: 2.28.0

bauersimon avatar Apr 09 '25 18:04 bauersimon

In any case: thanks for this cool piece of software!

bauersimon avatar Apr 09 '25 18:04 bauersimon

Hi! Another contributor handled the Nix package, which looks like it's out of date (0.5.0).

The most recent tplay release (0.6.1) aimed to be compatible with Ubuntu 24.

I don't have time right now to look into this but if you can try to install tplay 0.6.1 you might have better chances, OpenCV 4.10 issues permitting :)

maxcurzi avatar Apr 10 '25 06:04 maxcurzi

@colemickens Sorry for the ping. Could you have a look at this issue? And if possible provide a fix. Thanks ❤ in advance for the investigation and fix. 🙂

neon-mmd avatar Apr 19 '25 16:04 neon-mmd

  1. This should probably be filed on nixpkgs, not here.
  2. I don't know what's wrong. It doesn't build when I specifically build against ffmpeg_6:
       >    Compiling tplay v0.6.2 (/build/source)
       > error[E0061]: this function takes 2 arguments but 1 argument was supplied
       >    --> src/pipeline/runner.rs:430:26
       >     |
       > 430 |         let media_data = open_media(MEDIA_FILE.to_string()).unwrap();
       >     |                          ^^^^^^^^^^------------------------ argument #2 of type `std::string::String` is missing
       >     |
       > note: function defined here
       >    --> src/pipeline/frames.rs:150:8
       >     |
       > 150 | pub fn open_media(path: String, broswer: String) -> Result<MediaData, MyError> {
       >     |        ^^^^^^^^^^               ---------------
       > help: provide the argument
       >     |
       > 430 |         let media_data = open_media(MEDIA_FILE.to_string(), /* std::string::String */).unwrap();
       >     |                                                           +++++++++++++++++++++++++++
       >
       > For more information about this error, try `rustc --explain E0061`.
       > error: could not compile `tplay` (bin "tplay" test) due to 1 previous error

I opened a draft PR so someone else can maybe help: https://github.com/NixOS/nixpkgs/pull/420683

colemickens avatar Jun 28 '25 03:06 colemickens

This should really be closed.

  1. This project doesn't pass tests right now. Nix or otherwise, the tests weren't run before the latest push/release.

  2. This is also reported upstream already: https://github.com/NixOS/nixpkgs/issues/408027

colemickens avatar Jun 28 '25 04:06 colemickens

Hopefully this will merge soon and be fixed for unstable: https://github.com/NixOS/nixpkgs/pull/420683

I will not backport this, so, ymmv on a stable branch.

colemickens avatar Jun 28 '25 04:06 colemickens

thanks Cole for looking into this, I'll check that main is stable now and republish as needed

On Sat, 28 Jun 2025 at 05:13, Cole Mickens @.***> wrote:

colemickens left a comment (maxcurzi/tplay#56) https://github.com/maxcurzi/tplay/issues/56#issuecomment-3014929003

Hopefully this will merge soon and be fixed for unstable: NixOS/nixpkgs#420683 https://github.com/NixOS/nixpkgs/pull/420683

I will not backport this, so, ymmv on a stable branch.

— Reply to this email directly, view it on GitHub https://github.com/maxcurzi/tplay/issues/56#issuecomment-3014929003, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFQ5ARV4ARAZWG54ODT6L33FYI55AVCNFSM6AAAAAB2ZU4DLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJUHEZDSMBQGM . You are receiving this because you were assigned.Message ID: @.***>

maxcurzi avatar Jun 28 '25 10:06 maxcurzi

0.6.3 is now published, please follow https://github.com/NixOS/nixpkgs/pull/420683 for updates

maxcurzi avatar Jun 28 '25 16:06 maxcurzi