tplay icon indicating copy to clipboard operation
tplay copied to clipboard

update ffmpeg version

Open MoonDusk1996 opened this issue 1 year ago • 8 comments

I was facing difficulties when building this because of the ffmpeg version, in the process I realized that version 6.1 was what worked correctly for me, apparently there is no problem

MoonDusk1996 avatar Jan 10 '24 13:01 MoonDusk1996

I'll check it out. The Readme should not be changed because the FFMPEG (ffmpeg library) version number is supposed to be different from ffmpeg-next (cargo crate) as they are two different things. Can you check what version of ffmpeg do you have installed?

$ ffmpeg -version

for example:

ffmpeg version 4.4.2-0ubuntu0.22.04.1 Copyright (c) 2000-2021 the FFmpeg developers
built with gcc 11 (Ubuntu 11.2.0-19ubuntu1)

maxcurzi avatar Jan 10 '24 13:01 maxcurzi

In fact, I didn't know they were different things. This is my return:

ffmpeg version n6.1.1 Copyright (c) 2000-2023 the FFmpeg developers built with gcc 13.2.1 (GCC) 20230801

MoonDusk1996 avatar Jan 10 '24 18:01 MoonDusk1996

Building this fork on arch with rust works for me

MarelPup avatar Feb 01 '24 17:02 MarelPup

let's put a pin on it for the time being, obviously once we bump up the ffmpeg-next version the requirement for ffmpeg changes, and I want to make sure that the main ffmpeg library v6 has time to "settle" and be available everywhere before updating this system-wide library requirement

max-curzi avatar Feb 07 '24 12:02 max-curzi

I'd be interested to know if people managed to build and run tplay after updating ffmpeg to version 6... The crate that this project uses, ffmpeg-next, still doesn't support ffmpeg v6 ( I just tried)!

maxcurzi avatar Mar 26 '24 22:03 maxcurzi

(i'm Marelpup) the moondusk branch uses ffmpeg 6 and it seems to work fine

Guruk13 avatar Jun 30 '24 13:06 Guruk13

Sounds good, I'll try setting it up and update it once I have a bit of downtime!

maxcurzi avatar Jun 30 '24 17:06 maxcurzi

So I had some issues trying to install ffmpeg versions after 4 and as far as I understand it ffmpeg versions 6+ aren't supported on ubuntu 22.04.

It's nice to have the latest and greatest Ubuntu version but since the next LTS version (24.04) just came out (more or less) I don't want to suddenly drop support for ubuntu 22.04

apt policy ffmpeg
ffmpeg:
  Installed: 7:4.4.2-0ubuntu0.22.04.1
  Candidate: 7:4.4.2-0ubuntu0.22.04.1
  Version table:
 *** 7:4.4.2-0ubuntu0.22.04.1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages
        500 http://security.ubuntu.com/ubuntu jammy-security/universe amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy-security/universe amd64 Packages
        100 /var/lib/dpkg/status
     7:4.4.1-3ubuntu5 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy/universe amd64 Packages

A better solution would be for this crate to check if ffmpeg 6+ is installed and if so use the corresponding ffmpeg-next crate. It should be doable.

maxcurzi avatar Sep 10 '24 18:09 maxcurzi