Max Cao

Results 56 comments of Max Cao

> Oh boy, that's a bunch of conflicts :/ Yeah, I've been dreading these conflicts cause I've been working on both :-) > Can we also add some logic either...

> Can we also add some logic either to these new handlers or within ex. `RecordingArchiveHelper` so that the `sourceTarget` is verified to exist? I think think should be as...

> So we can apply the transformation of `cryostat:9091 -> service:jmx:rmi:///jndi/rmi://cryostat:9091/jmxrmi` early, at the API endpoints, rather than allowing those "bare" `host:port` values to trickle all the way down. Anything...

Ignoring tests, thoughts on the structure or anything else? The reason I have the migration and `TargetDiscoveryEvent` `accept` Archives logic in the `RecordingMetadataManager` is because I felt that both did...

I missed this in the other PR but noticed that you deprecated the `RecordingsPostHandler` and `RecordingsGetHandler` in the HTTP docs. Those are not being replaced in this PR so a...

> Archive migration doesn't seem to have worked for me: Whoops, I changed a method from returning null and null checking to run as a `CompletableFuture` and try catching it...

> Looks like this needs a `spotless:apply` and a rebase. > > I tried rebuilding and doing a migration again, with the following rule definition used to generate some archived...

> > There are also more exceptions at startup earlier on. Full logs attached. [cryostat-migration.log](https://github.com/cryostatio/cryostat/files/9647977/cryostat-migration.log) Also, looking at the log file, there seems to be logger prints there from a...

> RecordingArchiveHelper > I see this in the logs, too: > > ``` > java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because "targetId" is null > at io.cryostat.recordings.JvmIdHelper.getJvmId(JvmIdHelper.java:111) > at io.cryostat.recordings.JvmIdHelper.getJvmId(JvmIdHelper.java:124) > at...

> Seeing this error when running latest commit of this PR and [cryostatio/cryostat-web#499](https://github.com/cryostatio/cryostat-web/pull/499): > > ``` > SEVERE: HTTP 500: java.util.concurrent.ExecutionException: java.io.IOException > io.vertx.ext.web.handler.HttpException: Internal Server Error > Caused by:...