Max Cao
Max Cao
For some reason, I'm getting a Dagger Provides error for the `RecordingMetadataManager` even though I think the `PlatformClient` is getting provided here. Do you know why? It seems the `RuleProcessor`...
Everything according to the original issue description and @jan-law's updated PR description seems to be fixed, (other than 3 which is waiting on the corresponding -core PR merge). There was...
Ah, okay thanks for catching those, I'll look into both problems.
> Also, not sure if this is a backend or frontend bug, but when I run this and [cryostatio/cryostat-web#473](https://github.com/cryostatio/cryostat-web/pull/473) together, I get a hanging GraphQL request when I try to...
Oh, I see, we use targetIds as subdirectories so metadata may have "uploads" in the "targetId" key, I just need to check that in the code. Though this is about...
Seems like uploading a recording to the Archives view uses the old v1 `RecordingPostHandler` which doesn't handle metadata, and so when we go to edit it, we get a null...
> Rather than naming the files like `{base32(jvmId=recordingName)}.json`, would it make sense to create a `jvmId` subdirectory (or `{base32(jvmId)}`) and simply name the files as `{base32(recordingName)}.json`? I think this would...
Ignoring tests and v2 handlers, how does it look now? It's pretty much just adding another parameter to all the methods that have to be used and it all works...
Alright, then I will fix the issues, the v2 handlers, and the tests then.
Should I be using ApiException instead of HttpException for HTTP 406 in the V2 handlers? I noticed that they were implemented, but I'm not sure what the difference is.