Max Cao
Max Cao
Is it better to make new classes like `[Target]ReportEvalGetHandler` and do that or to add some option in the existing handlers if returning JSON, (as as form, path, or query)...
When do I know if I should update the v1 vs. v2 handlers or both? In my mind, this is a newer feature so it would make more sense to...
I'm looking at [vert.x docs ](https://vertx.io/docs/vertx-web/java/#_routing_based_on_mime_types_acceptable_by_the_client)and I see that the way they do produces and consumes is by using the route. The code is what I tried in the `ReportGetHandler`...
If a client adds a header ` Accept: image/webp ` but the `[Target]ReportGetHandler` doesn't accept this type, what should happen? Right now it is simply returning a `404 Not Found`...
Okay oneeee more problem sorry. What should be done in terms of the caching and such for returning the JSON? Right now the ReportService is being called from each HTTP...
About this PR, `ActiveRecording` metadata should be removed when cryostat is killed right, because right now in this PR it does not. I know @jan-law added a method called `removeLostTargetMetadata`...
Is there any way for the ITs to react to `Notifications` being emitted? The current implementation uses these `Notifications` to change metadata around when targets are lost and found. But...
> > there's probably no point in storing ActiveRecording metadata. > > If I'm understanding what you mean correctly, there is a point to storing it. The metadata in question...
> There is an integration test that reacts to notifications in #1028: > > https://github.com/cryostatio/cryostat/blob/f225aab038ae1ae65cb422322aa33b2ec463fd56/src/test/java/itest/CustomTargetsIT.java I've been trying to figure this out, and have used some of the things in...
> Not sure what you mean here - when you write/run an integration test, the client is the `IT.java` class and the server is the actual Cryostat instance in the...