Max Brunsfeld

Results 494 comments of Max Brunsfeld

It's useful to include some preprocessor directives (like `#if`/`#else`, etc) in the main grammar, because we want those constructs represented structurally in the syntax tree, which allow you to do...

> Is breaking backwards compatibility to fix this worth it though? Yeah, I think it's actually ok to rename it. Thanks for taking a critical look.

Can you report the output of `tree-sitter parse ` for the code that you're matching? It sounds like there is just a syntax error happening, so that we have a...

Simpler runnable example: ```sh $ echo \ # hi ``` Prints: ``` # hi ```

I agree; it'd be better to not have the trailing newline as part of the node.

> every child of a block is a statement This seems like a good change. > why does test --update make a bunch of unnecessary whitespace changes? It is reformatting...

Can you upgrade to the latest Tree-sitter and regenerate with that? Currently, the latest version is 0.20.6.

Could you provide a code example, a description of the parse tree you'd expect, and a link to the description of the language feature in question?

I think we'd probably want to solve this by making a specific grammar just for Doxygen, and then parsing C++ comments using that grammar, via language *injection*. I'm not familiar...

The `...` token is in there and you can access it, but it isn't *named*, so it doesn't show up in the printed tree. Maybe it should be given a...