Max Beckers

Results 20 comments of Max Beckers

Seems, that the modification of the regex happens here: https://github.com/symfony/routing/blob/5.4/RouteCompiler.php#L310-L313

@berkut1 oh yes, you're right. You figured out the correct line, modifying your regex. but i think you can modify your regex like this `\/locations\/(?|([a-z0-9]+(-?[a-z0-9]+)*)(\/buildings){0,1})` to simpify it a bit...

You're right, regex is for me too always a hard topic. Detecting bugs is not that easy. Just a help, how I handle url regex problems: You can use `symfony...

I like the idea of renaming `$request->request`. But why form? This sounds to me as well confusing, because its maybe formdata, but not the form. I'd prefer to name it...

Yes, you are absolutely right. There are exactly these 3 topics here in this issue. Thanks for clarifying. And yes you are right, from the naming point of view body...

IMHO it souds to be a great idea to have a component/bundle in the symfony eco system with the functionallity. Having metrics (for Prometheus) of the application and sth like...

@patrickkusebauch @dbrumann can this issue be closed with #1029? Or is here still sth to do like integrating a windows env in the build pipeline (not needed IMHO)

> any reason why we don't add a windows github action job? What's the benefit you expect of such a github action job?

Yes of course, but do you see just a failing test on a windows mashine because of a lineending problem or whatever, fixed in a few minutes when someone realizes...

I like the idea to reduce the complexity in the code 👍 But of course the migration could be a big issue for some applications (and can not be done...