Max Arturo AS

Results 48 comments of Max Arturo AS

I've woefully neglected this little project of mine. Comic.js looks killer, though it seems to mess up something of the d3 transitions in the examples. I'll certainly look into it....

I ran into this earlier and thought the same thing as the commenters here. @scotttrinh @colinhacks I'd love to take a stab at submitting a PR that solves this generally....

Please take a look at #1589, would love to know your thoughts. It addresses several of the issues listed here: > The following are now well-supported discriminator values (enum/undefined could...

Hello @tianhuil @scotttrinh ! I'm wondering if this is still being worked on? It seems that the PR's feature [already works](https://github.com/colinhacks/zod/issues/1075#issuecomment-1324937116). Just asking because I ran into this while implementing...

@mcky @sdirosa wanted to make you aware of some WIP work I've taken on re: this in https://github.com/colinhacks/zod/pull/1589. I'm looking around for expected use cases and ran into this issue;...

Looks like we can take off the `awaiting-pull-request` label @JacobWeisenburger !

@JacobWeisenburger you're correct - the suggestion with `z.tuple()` makes it so we expect an array with the original parameters which is likely not what @hyusetiawan intends. I think here unfortunately...

There's an open PR for this @gligoran https://github.com/colinhacks/zod/pull/1589. The functionality will hopefully also be upgraded with `intersection`s and other Zod types that make sense.

@DanielBreiner thanks for the PR! Good observation re: `refinement` method. Given that there's now - `refine()` - `refinement()` - `superRefine()` - possibly `megaRefine()` (just joking :D) I wonder if the...

> Whats your take? How should I integrate those changes into Zod's current codebase? IMO this seems very sensible - especially since there's no API changes and seems in line...