Maximilian Roos

Results 514 comments of Maximilian Roos

Not an expert here, but presumably if a file uses the same name for differently sized dimensions, xarray isn't going to be able to open it? One workaround may be...

> If you want to control the behavior of dropping attrs from variables or only dataset level attrs is another question. +1 What are variable-level attrs generally used for? For...

> But should probably have the same arguments and workings as `drop_vars` and others. Yes, I was thinking about it a bit more like `.reset_encoding` — #8259. We could definitely...

Hi team — what do we think about this? @pydata/xarray

Thanks for the review @crusaderky . I realize it's much easier to review when there are tests; I added those

> My main concern is the meaning of "drop attrs" could be confusing: I'm very open-minded here! My main motivation is to put less weight on `keep_attrs` parameter throughout the...

I've now added a `deep` kwarg, which controls whether it clears the attrs of all variables. I've provisionally set it as `deep=True`. This is more aggressive than `keep_attrs`. What do...

@pydata/xarray I realize this is still hanging! What's the best way of resolving? My guess is that there's consensus that the method would be useful, but maybe not on how...

Thanks for the issue. What would you expect the output to be? It does seem surprising that passing two arguments succeeds while passing each of them alone succeeds... A partial...

> * con: if we require `set_indexes` in the signature in addition to the `drop_variables` parameter, this is a breaking change for all existing 3rd-party backends Doesn't help with the...