Maximilian Roos

Results 1196 comments of Maximilian Roos

Looks great, I think this is indeed very close to landing. The one thing I'm stuck on is the concept of `fill_direction="backward" ... .ffill...` — can we explain what the...

Yes, I see what it does, but (very very respectfully, with much admiration for the overall PR!), it doesn't make semantic sense to me. When I think "backward", I mean...

Ha, thanks a lot for the drawing! I appreciate it! FWIW the step there that didn't make sense to me is "one step backward" for `bfill` & `ffill` — my...

Great! For the name, a verb is consistent with the existing interface (`resample`, `groupby`, etc). `fill_gaps` seems quite reasonable, and I can't think of anything that's a single word... ...unless ...

> How about `gapfill`? Two characters less than `fill_gaps`, single word and verb. Does `gapfill` go against the python convention of separating words with underscores? (I don't want to bikeshed,...

> The difficulty with doing this by default, i.e. when running cargo msrv verify from a workspace root, is that you'll have to disambiguate between "running verify against a root...

Is this still current?

yes, great table > My take on this is: > > 1. no for the default > > 2. yes for the opt-in parameter, I agree. sounds very reasonable!

Interesting, I haven't seen this before. Does the full log at `/home/vscode/.npm/_logs/2024-10-19T22_57_39_755Z-debug-0.log` have anything interesting? Does running whatever inner command is run based on `spawnargs: [ 'build', '--target', 'nodejs', '--out-dir',...

This is because the data type of the array is `