concat-stream

concat-stream copied to clipboard

stevemao

Apply the same logic as a4b2ea249a795160806f588a3d305333c22be44a to the tests.

tomhughes

Use standard, error-first callbacks

4

Drawn from #15. Let's discuss in a separate issue. jonathanong on Dec 1, 2013 > `callback(err, data)` - it's a callback, not an event listener, so imo it should have...

zenflow

https://github.com/mafintosh/end-of-stream

kumavis

v2 ideas

4

you asked to help maintain this library, so here are some thoughts: - streams2 implementation, shouldn't be hard with `readable-stream`. - i don't like the type inferencing in `getBody`. prefer...

jonathanong

concat-stream - buffer object in callback is empty.

4

See the following piece of code. ``` var concat = require('concat-stream'); var src = // some stream which contains non-utf-8 content for ex : shift_jis var dest = // it...

sharmalalit

I'm not sure this is a big deal, but the encoding inference can cause issues when using `objectMode` streams and not specifying that the encoding is objects to concat-stream. I...

brycebaril

Would you be open to a PR that bumps minimum supported version and gets rid of the polyfills, to make the library more lightweight and suitable for the modern runtime...

kibertoad