concat-stream icon indicating copy to clipboard operation
concat-stream copied to clipboard

Remove unused `isArray` polyfill

Open kenany opened this issue 11 years ago • 7 comments

Not being used anywhere. Or, should it be used here?

kenany avatar Nov 11 '14 17:11 kenany

:+1: for just removing it. Users can add another isArray polyfill as needed.

shinnn avatar Jun 10 '15 18:06 shinnn

:+1:

stevemao avatar Jun 30 '15 01:06 stevemao

better to use the isarray module.

ljharb avatar Apr 15 '16 23:04 ljharb

@maxogden @mafintosh how about merging this?

eagleeye avatar Jun 08 '17 10:06 eagleeye

https://github.com/maxogden/concat-stream/pull/32#issuecomment-210683044

ljharb avatar Jun 08 '17 16:06 ljharb

Could also do that if desired (note, that specific module is deprecated, but there are others).

kenany avatar Jun 08 '17 16:06 kenany

That deprecation only applies to v2, and is simply a paternalistic way of trying to push people not to support ES3. You can and should use v1 of that package for the foreseeable future.

ljharb avatar Jun 08 '17 16:06 ljharb